Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix serialize test #1312

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix serialize test #1312

merged 1 commit into from
Feb 27, 2023

Conversation

Lo1nt
Copy link
Collaborator

@Lo1nt Lo1nt commented Feb 27, 2023

Motivation:

fix test case

@Lo1nt Lo1nt self-assigned this Feb 27, 2023
@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/S labels Feb 27, 2023
@Lo1nt Lo1nt force-pushed the fix_serialize_test branch from b25ea5d to 4ce453e Compare February 27, 2023 05:28
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1312 (7365f0c) into master (af35a32) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1312      +/-   ##
============================================
+ Coverage     71.96%   72.01%   +0.05%     
+ Complexity      784      783       -1     
============================================
  Files           415      415              
  Lines         17651    17651              
  Branches       2753     2753              
============================================
+ Hits          12702    12712      +10     
+ Misses         3547     3535      -12     
- Partials       1402     1404       +2     
Impacted Files Coverage Δ
...ofa/rpc/registry/consul/HealthServiceInformer.java 84.78% <0.00%> (-4.35%) ⬇️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 80.00% <0.00%> (-4.00%) ⬇️
...alipay/sofa/rpc/codec/protobuf/ProtobufHelper.java 77.08% <0.00%> (-2.09%) ⬇️
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 87.30% <0.00%> (-1.59%) ⬇️
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 88.88% <0.00%> (-1.24%) ⬇️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 56.14% <0.00%> (-0.88%) ⬇️
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 61.02% <0.00%> (+0.25%) ⬆️
.../alipay/sofa/rpc/registry/local/LocalRegistry.java 72.15% <0.00%> (+5.11%) ⬆️
...java/com/alipay/sofa/rpc/module/LookoutModule.java 85.71% <0.00%> (+33.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sofastack-bot sofastack-bot bot added size/M and removed size/L labels Feb 27, 2023
@Lo1nt Lo1nt force-pushed the fix_serialize_test branch from 6b0138d to 7365f0c Compare February 27, 2023 10:05
@sofastack-bot sofastack-bot bot added size/XS and removed size/M labels Feb 27, 2023
@Lo1nt Lo1nt marked this pull request as ready for review February 27, 2023 11:06
Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit 75bc1ff into sofastack:master Feb 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working cla:yes CLA is ok size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants