Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[202405]Fix test_cacl_application for latest change in caclmgrd #13900

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

ZhaohuiS
Copy link
Contributor

@ZhaohuiS ZhaohuiS commented Jul 31, 2024

Description of PR

Summary:
Fixes # (issue)
According PR sonic-net/sonic-host-services#139, the expected iptables rules are changed.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Fix PR test failure in sonic-net/sonic-buildimage#19732

How did you do it?

modify expected iptable rules in test_cacl_application case due to image change.
skip cacl/test_cacl_application.py for 202405 branch temporarily

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

ZhaohuiS and others added 2 commits July 31, 2024 08:08
)

What is the motivation for this PR?
RP test will fail after sonic-net/sonic-host-services#139, update the case accordingly.

How did you do it?
add expected iptable rules

How did you verify/test it?
run cacl/test_cacl_application.py

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
@ZhaohuiS ZhaohuiS changed the title Fix/skip cacl 202405 [202405]Fix test_cacl_application for latest change in caclmgrd Jul 31, 2024
@wangxin wangxin merged commit c141c09 into sonic-net:202405 Aug 2, 2024
14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants