Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[202405]Fix test_cacl_application for latest change in caclmgrd #13900

Merged
merged 2 commits into from
Aug 2, 2024
Merged

[202405]Fix test_cacl_application for latest change in caclmgrd #13900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2582c9a
Fix test_cacl_application for latest change in caclmgrd (#13786)
ZhaohuiS Jul 29, 2024
6b51dce
add test_cacl_application back into pr_test_sripts
ZhaohuiS Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/cacl/test_cacl_application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,13 @@ def generate_expected_rules(duthost, tbinfo, docker_network, asic_index, expecte
generate_and_append_block_ip2me_traffic_rules(duthost, iptables_rules, ip6tables_rules, asic_index)

# Allow all packets with a TTL/hop limit of 0 or 1
iptables_rules.append("-A INPUT -m ttl --ttl-lt 2 -j ACCEPT")
ip6tables_rules.append("-A INPUT -p tcp -m hl --hl-lt 2 -j ACCEPT")
iptables_rules.append("-A INPUT -p icmp -m ttl --ttl-lt 2 -j ACCEPT")
iptables_rules.append("-A INPUT -p udp -m ttl --ttl-lt 2 -m udp --dport 1025:65535 -j ACCEPT")
iptables_rules.append("-A INPUT -p tcp -m ttl --ttl-lt 2 -m tcp --dport 1025:65535 -j ACCEPT")

ip6tables_rules.append("-A INPUT -p ipv6-icmp -m hl --hl-lt 2 -j ACCEPT")
ip6tables_rules.append("-A INPUT -p udp -m hl --hl-lt 2 -m udp --dport 1025:65535 -j ACCEPT")
ip6tables_rules.append("-A INPUT -p tcp -m hl --hl-lt 2 -m tcp --dport 1025:65535 -j ACCEPT")

# If we have added rules from the device config, we lastly add default drop rules
if rules_applied_from_config > 0:
Expand Down
6 changes: 6 additions & 0 deletions tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,12 @@ bgp/test_traffic_shift.py::test_load_minigraph_with_traffic_shift_away:
#######################################
##### cacl #####
#######################################
cacl/test_cacl_application.py:
skip:
reason: "Skip test_cacl_application temporarily due to known issue"
conditions:
- https://github.com/sonic-net/sonic-mgmt/issues/13805

cacl/test_cacl_application.py::test_cacl_application_dualtor:
skip:
reason: "test_cacl_application_dualtor is only supported on dualtor topology"
Expand Down
Loading