Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add static DNS test cases #8712

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

nhe-NV
Copy link
Contributor

@nhe-NV nhe-NV commented Jun 25, 2023

4 test cases added to verify the static DNS feature Here PR for the test plan: #8436

Description of PR

Summary: Add new test cases to cover the static dns feature. sonic-net/SONiC#1262
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

Add test cases to cover the static dns feature

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@liat-grozovik
Copy link
Collaborator

@oleksandrivantsiv please review
@nhe-NV please handle conflicts

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/devices/sonic.py:472:5: E303 too many blank lines (2)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@nhe-NV nhe-NV force-pushed the add_static_dns_testcases branch from e63b077 to 50a836c Compare September 26, 2023 07:55
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/devices/sonic.py:472:5: E303 too many blank lines (2)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@nhe-NV nhe-NV force-pushed the add_static_dns_testcases branch from 50a836c to 420a692 Compare September 27, 2023 11:20
@nhe-NV nhe-NV requested a review from roy-sror November 5, 2023 04:49
@qiluo-msft qiluo-msft requested a review from ganglyu December 4, 2023 17:59
@ganglyu ganglyu requested a review from saiarcot895 December 4, 2023 23:15
@ganglyu
Copy link
Contributor

ganglyu commented Dec 4, 2023

@saiarcot895
Would you please check this PR? Might have conflict with your test.

@liat-grozovik
Copy link
Collaborator

if there is no other PR for the test by @saiarcot895 this should go first and then be fixed on the other.
@saiarcot895 @ganglyu please help to close. this is 202311 feature and test should be avaialble for this branch

@ganglyu
Copy link
Contributor

ganglyu commented Dec 11, 2023

if there is no other PR for the test by @saiarcot895 this should go first and then be fixed on the other. @saiarcot895 @ganglyu please help to close. this is 202311 feature and test should be avaialble for this branch

Hi, I have checked with @saiarcot895, there's no conflict, please merge this PR.

@nhe-NV
Copy link
Contributor Author

nhe-NV commented Dec 12, 2023

@qiluo-msft can you help to merge this PR?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants