[202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…techsupport dump Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
liat-grozovik
approved these changes
Dec 29, 2022
8 tasks
|
@vadymhlushko-mlnx shouldn't this also be on the master branch? it has the same changes to the flows of generate dump on there. |
|
vadymhlushko-mlnx
added a commit
to vadymhlushko-mlnx/sonic-utilities
that referenced
this pull request
Jan 5, 2023
"[202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (sonic-net#2572)" "[generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (sonic-net#2565)" "[202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (sonic-net#2562)" This reverts commits e1c8243 f45dcfb 93172c4
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 5, 2023
- What I did Reverted PRs because they caused the degradation that some files are missing in show techsupport archive. - How I did it Reverts the following e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (#2572) f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (#2565) 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (#2562)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vadym Hlushko vadymh@nvidia.com
What I did
Fixed a deletion flow for all secret files in the tech support dump.
How I did it
Delete files by using the
findandrmLinux utilities.How to verify it
Run the show_techsupport/test_techsupport_no_secret.py
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)