[202205] Revert the show-techsupport optimization PR's #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"[202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (sonic-net#2572)" "[generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (sonic-net#2565)" "[202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (sonic-net#2562)" This reverts commits e1c8243 f45dcfb 93172c4
liat-grozovik
approved these changes
Jan 5, 2023
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Jan 5, 2023
Update sonic-utilities submodule pointer to include the following: * dddd6c5 [202205] Revert the show-techsupport optimization PR's ([sonic-net#2581](sonic-net/sonic-utilities#2581)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jan 5, 2023
Update sonic-utilities submodule pointer to include the following: * dddd6c5 [202205] Revert the show-techsupport optimization PR's ([#2581](sonic-net/sonic-utilities#2581)) Signed-off-by: dprital <drorp@nvidia.com>
StormLiangMS
added
Request for 202211 Branch
and removed
Request for 202211 Branch
labels
vadymhlushko-mlnx
added a commit
to vadymhlushko-mlnx/sonic-utilities
that referenced
this pull request
Jan 10, 2023
…c-net#2581)" This reverts commit dddd6c5.
vadymhlushko-mlnx
added a commit
to vadymhlushko-mlnx/sonic-utilities
that referenced
this pull request
Mar 1, 2023
…-net#2581)" This reverts commit dddd6c5.
yxieca
pushed a commit
that referenced
this pull request
Mar 16, 2023
…#2581", add fixes for empty /dump forder and symbolic links (#2711) * Revert "[202205] Revert the show-techsupport optimization PR's (#2581)" This reverts commit dddd6c5. * [generate_dump] Fix for empty /dump folder Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com> * [generate_dump] Fix for symlinks in collect_mellanox_dfw_dumps() Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com> --------- Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Reverted PRs because they caused the degradation that some files are missing in
show techsupport archive.How I did it
Revert the:
e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (#2572)
f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (#2565)
93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (#2562)
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)