Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ohai plugin deprication warning #239

Closed
damacus opened this issue Jul 1, 2014 · 8 comments
Closed

Ohai plugin deprication warning #239

damacus opened this issue Jul 1, 2014 · 8 comments

Comments

@damacus
Copy link
Member

damacus commented Jul 1, 2014

/etc/chef/ohai_plugins/nginx.rb is a version 6 plugin this will be deprecated in future versions of ohai.

@miketheman
Copy link
Contributor

@damacus Thanks for the report.
Since Chef 10 (and thereby Ohai 6) is still widely used, we'd need to continue to keep this backwards compatible for a while.
Would you like to try creating a code change (and associated tests) for this?
See here: http://docs.getchef.com/ohai.html#ohai-6-vs-ohai-7-plugins for examples

@damacus
Copy link
Member Author

damacus commented Jul 29, 2014

No problem I'll see what I can come up with. Thanks for the links to the
new documentation.
On 29 Jul 2014 13:30, "Mike Fiedler" notifications@github.com wrote:

@damacus https://github.com/damacus Thanks for the report.
Since Chef 10 (and thereby Ohai 6) is still widely used, we'd need to
continue to keep this backwards compatible for a while.
Would you like to try creating a code change (and associated tests) for
this?
See here: http://docs.getchef.com/ohai.html#ohai-6-vs-ohai-7-plugins for
examples


Reply to this email directly or view it on GitHub
#239 (comment).

@miketheman miketheman added this to the Triage milestone Aug 23, 2014
@tas50
Copy link
Contributor

tas50 commented Sep 30, 2014

Would you be open to creating 2 plugins and loading the correct version based on the version of Ohai present?

@miketheman
Copy link
Contributor

@tas50 I am led to believe that using Ohai 7 plugins with Ohai 6 is compatible, obviating the need for two plugins and more switching logic.

I have not tested this yet.

@spajus
Copy link

spajus commented Apr 7, 2015

Few thoughts that could get this moving. Perhaps it would be possible to use node attributes to choose which ohai plugin version to use? Another option - to detect chef version and to choose which type of nginx ohai plugin to load accordingly?

@tas50
Copy link
Contributor

tas50 commented Aug 2, 2016

#422 includes a fix for this by shipping a v7 plugin on v7+ hosts

@tas50
Copy link
Contributor

tas50 commented Aug 12, 2016

This particular issue has been pulled into the chef_nginx cookbook 2.8.0 release. The chef_nginx cookbook is a fork of this cookbook with many of the outstanding issues in the 2.7.6 release resolved. The release is backwards compatible with this cookbook outside of the name change, which obviously requires updating runlist and and metadata dependencies. I'd highly suggest giving it a try to see if this resolves you nginx cookbook woes.

https://github.com/chef-cookbooks/chef_nginx
https://supermarket.chef.io/cookbooks/chef_nginx#changelog

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants