Release 2.8.0 with critical fixes + testing improvements #422
Conversation
In latest passenger versions location of nginx module has changed: https://github.com/phusion/passenger/tree/release-5.0.19
checksum updated as of 05-01-2016
We already require this in the metadata. There's no need for it here. Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Exclude the current issues Signed-off-by: Tim Smith <tsmith@chef.io>
Use the latest Chef file Signed-off-by: Tim Smith <tsmith@chef.io>
This reduces the amount of time to takes to pull down the cookbook by skipping testing files Signed-off-by: Tim Smith <tsmith@chef.io>
Attributes should no longer be included in the metadata file Add our new supermarket metadata Signed-off-by: Tim Smith <tsmith@chef.io>
Disable the extra spacing rule since it only partially fixes the resource alignment Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Use server runner since chef solo is now just local mode in disguise Update to a modern Debian release Quiet the insane number of Ohai warnings when running the specs Signed-off-by: Tim Smith <tsmith@chef.io>
Disable guard-foodcritic for now Signed-off-by: Tim Smith <tsmith@chef.io>
This is our current standard Chef rakefile that includes some error handling and improved testing Signed-off-by: Tim Smith <tsmith@chef.io>
The defaults are scary out of date here Signed-off-by: Tim Smith <tsmith@chef.io>
Lawyers and stuff Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Instead of using root_group we should just let chef do the right thing with the defaults. Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Checking for a process without shell expansion always returns 0. This test was busted Signed-off-by: Tim Smith <tsmith@chef.io>
Also the nginx command output test never worked. It was checking stdout not stderr Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
changed the title
This is 99% from https://raw.githubusercontent.com/h5bp/server-configs-nginx/master/mime.types Signed-off-by: Tim Smith <tsmith@chef.io>
|
Any update on this ? |
|
@JorisAndrade If this PR is like any of the others, it will go unnoticed, and unmerged for months. And we'll see the spawn of nginx-ng and nginx2, not to mention nginx-ng2 type cookbooks. If the supermarket and berkshelf supported namespacing, we could avoid this by having the community naturally carry on enhancements and development on a fork. As it is, a well established cookbook that ends up being abandoned is really difficult to get moving again, and most likely requires a name change. Not ideal. |
|
@predominant Unfortunately it does appear that we won't be able to get this pull request merged. We've chosen instead to pull this branch and PR into our chef-cookbooks org and continue work on it there. This cookbook has been released as chef_nginx. Obviously this less than ideal as you stated above, but I think a Chef maintained version of the cookbook will live on even if individual maintainers come and go. I'd highly recommend everyone check out that new cookbook. It solves the issues above and includes some improved testing and updates. I plan to release a 3.0 version soon that support Chef 12+ only and then work towards adding custom resources to make writing wrapper cookbooks easier. https://supermarket.chef.io/cookbooks/chef_nginx |
|
Closing this in favor of a full merge of chef_nginx back into the cookbook |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This gets us a working 2.X release before shifting gears to 3.X completely. It rolls up a few simple, but incredibly important fixes that have been causing a lot of pain for customers and the community as a whole. It also updates testing with addition platforms, inspec, a simplified rakefile, and cookstyle.
This change is