You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fire up Imviz example notebook and load the images.
In Plot Options, change Color Mode to Monochromatic (make sure you select the second image, which is what you will be seeing first).
In the notebook cell, run imviz.default_viewer.set_colormap('Viridis') and then observe the state of Plot Options.
@kecnry and I apparently observed different behavior, both which were a little counter-intuitive (either the image does not change back to colormap or it did but Plot Options didn't).
What should be the desired behavior? Kyle presented 3 possible solutions:
Change the colormode on the viewer to colormap and the colormap on the top layer (or all layers?) to whatever is requested
Set the underlying state, but require manually changing the mode. This is what I’d expect, but that’s probably because I know what happens at the low level with the state objects
Raise an error requiring mode to be changed first (or perhaps passing an additional argument to set_colormap)
Kyle: I’d probably vote for 3, because I like error messages and being very clear when some magic is happening. But if 1 is consistent with astrowidget API, then we can make that happen… although its odd that you’re seeing it happen now and I don’t. Nowhere in astrowidgets does that logic exist, so is glue triggering a change to the mode somewhere? Do you actually see the mode dropdown change to "colormaps"?
POs should decide which option would make most sense to a typical scientist user.
DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen
The text was updated successfully, but these errors were encountered:
Reporter: pllim
Workflow:
imviz.default_viewer.set_colormap('Viridis')
and then observe the state of Plot Options.@kecnry and I apparently observed different behavior, both which were a little counter-intuitive (either the image does not change back to colormap or it did but Plot Options didn't).
What should be the desired behavior? Kyle presented 3 possible solutions:
set_colormap
)Kyle: I’d probably vote for 3, because I like error messages and being very clear when some magic is happening. But if 1 is consistent with astrowidget API, then we can make that happen… although its odd that you’re seeing it happen now and I don’t. Nowhere in astrowidgets does that logic exist, so is glue triggering a change to the mode somewhere? Do you actually see the mode dropdown change to "colormaps"?
POs should decide which option would make most sense to a typical scientist user.
Related issues:
🐱
DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen
The text was updated successfully, but these errors were encountered: