Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix setting plot options state when setting cmap through API #1507

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jul 19, 2022

Description

This pull request fixes setting the plot options state for colormap when set through the API (either by manually setting the glue-state or through the astrowidgets API).

Fixes #1506

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added bug Something isn't working trivial Only needs one approval instead of two labels Jul 19, 2022
@kecnry kecnry added this to the 2.8 milestone Jul 19, 2022
@kecnry kecnry force-pushed the fix-plot-options-set-colormap branch from 2d7ba7f to e82a0c3 Compare July 19, 2022 12:37
@kecnry kecnry added the plugin Label for plugins common to multiple configurations label Jul 19, 2022
@kecnry kecnry marked this pull request as ready for review July 19, 2022 12:48
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1507 (e82a0c3) into main (d24f823) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1507   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files          91       91           
  Lines        8551     8551           
=======================================
  Hits         7308     7308           
  Misses       1243     1243           
Impacted Files Coverage Δ
jdaviz/core/template_mixin.py 91.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24f823...e82a0c3. Read the comment docs.

@pllim pllim added the imviz label Jul 19, 2022
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works if the Color Mode stays in Colormap mode, which I think that this PR wants to fix.

But we should open a follow up ticket for bug of viewer.set_colormap('Viridis') not updating Plot Options when Color Mode is in Monochromatic mode, which might be related to #1504 .

Thanks for the quick fix!

@pllim pllim merged commit 211696a into spacetelescope:main Jul 19, 2022
@kecnry kecnry deleted the fix-plot-options-set-colormap branch July 19, 2022 19:12
@pllim
Copy link
Contributor

pllim commented Jul 19, 2022

Follow-up issue at #1510

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working imviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imviz set_colormap does not update Plot Options correctly
2 participants