Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

improve moment validation message #1536

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 1, 2022

Description

This pull request improves the UI-validation of the moment number in the moment map plugin. Previously, it used to trigger "This field is required" when setting moment to 0, but now will only trigger that message when empty and with a separate validation message when negative

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 2.9 milestone Aug 1, 2022
* used to trigger "This field is required" when setting moment to 0, now will only trigger when empty and with a separate validation message when negative
@kecnry kecnry force-pushed the moment-validation branch from dafceff to 560d868 Compare August 1, 2022 16:42
@kecnry kecnry added the trivial Only needs one approval instead of two label Aug 1, 2022
@kecnry kecnry marked this pull request as ready for review August 1, 2022 16:43
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems uncontroversial enough. Thanks!

@pllim pllim merged commit 55f5b5e into spacetelescope:main Aug 1, 2022
@kecnry kecnry deleted the moment-validation branch August 1, 2022 18:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cubeviz trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants