Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

improve moment validation message #1536

Merged
merged 1 commit into from
Aug 1, 2022
Merged

improve moment validation message #1536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ Bug Fixes
Cubeviz
^^^^^^^

- Fixed validation message of moment number in moment map plugin. [#1536]

Imviz
^^^^^

Expand Down
3 changes: 2 additions & 1 deletion jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
v-model.number="n_moment"
hint="The desired moment."
persistent-hint
:rules="[() => !!n_moment || 'This field is required']"
:rules="[() => n_moment !== '' || 'This field is required',
() => n_moment >=0 || 'Moment must be positive']"
></v-text-field>
</v-row>

Expand Down