Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT: Bump bqplot minversion to 0.12.29 #670

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 8, 2021

Bump bqplot minversion to 0.12.29 for Jupyter Lab support. cc @maartenbreddels

Fix #327
Fix #661

for Jupyter Lab support.
@pllim pllim requested a review from eteq June 8, 2021 18:45
@pllim pllim added bug Something isn't working Ready for final review labels Jun 8, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #670 (3ad2201) into main (1aa0dce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   59.60%   59.60%           
=======================================
  Files          65       65           
  Lines        4005     4005           
=======================================
  Hits         2387     2387           
  Misses       1618     1618           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa0dce...3ad2201. Read the comment docs.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to break anything in notebook mode, but I'm having trouble with Jupyter Lab so I can't currently confirm that this fixes those issues. Approving, but I'd like someone to get it working in Lab...

@ojustino ojustino self-requested a review June 16, 2021 20:21
Copy link
Contributor

@ojustino ojustino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added myself as a reviewer to report that Specviz seems to work as intended when I run it in Jupyter Lab... but I also never experienced issue #661 even while using version 0.12.27 of bqplot. The solution in #625 on its own was enough for me for whatever reason. As such, it might be good to get feedback from other Lab users.

@rosteen
Copy link
Collaborator

rosteen commented Jun 21, 2021

@ojustino Thanks, I think it's enough to know that this at least doesn't break Lab usage for you. I can figure out my problems separate from this simple version bump.

@rosteen rosteen merged commit ede4fec into spacetelescope:main Jun 21, 2021
@pllim pllim deleted the bump-bqplot-0.12.29 branch June 21, 2021 13:38
@pllim
Copy link
Contributor Author

pllim commented Jun 21, 2021

@rosteen , FWIW, I created a fresh conda env with Python 3.9 + Lab 3 and the "model" error is gone; Imviz works for that combo for me.

@rosteen
Copy link
Collaborator

rosteen commented Jun 21, 2021

I was about to ask if you had solved that problem, thanks!

@pllim
Copy link
Contributor Author

pllim commented Jun 21, 2021

One does wonder what went wrong with the old combo but one does not wish to jump into that particular rabbit hole.

@rosteen
Copy link
Collaborator

rosteen commented Jun 21, 2021

Another one agrees XD

I have it working now in a fresh environment as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plots do not appear in jupyter lab Jupyter Lab JDAViz/Specviz Compatibility
3 participants