-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
MNT: Bump bqplot minversion to 0.12.29 #670
Conversation
for Jupyter Lab support.
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
=======================================
Coverage 59.60% 59.60%
=======================================
Files 65 65
Lines 4005 4005
=======================================
Hits 2387 2387
Misses 1618 1618 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to break anything in notebook mode, but I'm having trouble with Jupyter Lab so I can't currently confirm that this fixes those issues. Approving, but I'd like someone to get it working in Lab...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added myself as a reviewer to report that Specviz seems to work as intended when I run it in Jupyter Lab... but I also never experienced issue #661 even while using version 0.12.27 of bqplot
. The solution in #625 on its own was enough for me for whatever reason. As such, it might be good to get feedback from other Lab users.
@ojustino Thanks, I think it's enough to know that this at least doesn't break Lab usage for you. I can figure out my problems separate from this simple version bump. |
@rosteen , FWIW, I created a fresh conda env with Python 3.9 + Lab 3 and the "model" error is gone; Imviz works for that combo for me. |
I was about to ask if you had solved that problem, thanks! |
One does wonder what went wrong with the old combo but one does not wish to jump into that particular rabbit hole. |
Another one agrees XD I have it working now in a fresh environment as well. |
Bump bqplot minversion to 0.12.29 for Jupyter Lab support. cc @maartenbreddels
Fix #327
Fix #661