active state for toolbar buttons #940
Conversation
* orange background color by applying the "active" class * rename !collapse -> tools_open (and create data_open and layer_viewer_open) * allow toolbar-items styling (block buttons in toolbars instead of circles) to pass through tooltip wrapping spans * replace plugin icon with hamburger * remove X when hammer-screwdriver is active * replace lock icon in mosviz with link icon (was temporarily lock/unlocked icon to have two states - this is no longer needed with the active state)
kecnry
requested review from
duytnguyendtn,
ibusko,
javerbukh,
ojustino,
pllim and
rosteen
as code owners
kecnry
added
no-changelog-entry-needed
Codecov Report
@@ Coverage Diff @@
## main #940 +/- ##
==========================================
+ Coverage 69.37% 69.38% +0.01%
==========================================
Files 69 69
Lines 4888 4887 -1
==========================================
Hits 3391 3391
+ Misses 1497 1496 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I am a fan of this. It is certainly more intuitive for me. Two comments below.
- Is it intentional that the sub-menu (e.g., region selection) does not have the same active state color scheme?
- Will it be confusing that
IMPORT +now visually look like it is always "active"?
Not intentional or unintentional... we can try to do orange there as well (the plotting toolbar is slightly out of our control as its pulled in directly from upstream, but I think it should be feasible to override the styling since they clearly already have an active state, probably through toggle buttons), but then we may need to change the icon colors and/or the inactive background color as well. This is another good question for Jenn.
I agree, and Jenn said she would open another ticket to reconsider the design and emphasis on the import button. |
There was a problem hiding this comment.
Given answers in #940 (comment) , my comments can be addressed as future PRs.
|
@PatrickOgle I am hopeful that users will quickly learn to click on the hammer because all menus will follow that same pattern. That said I think it is something to watch out for during usability testing. If it seems like no one is getting it we can reconsider! I agree with @pllim 's comment about the secondary header also following the same selection pattern. It would be nice if they were also styled the same. |
Description
This pull request adds support for an active state (orange background) to all toolbar buttons. In doing so, it fixes block button instead of circle styling for toolbar buttons (only visible before when hovering, but required for proper shading for new active state), replaces the plugin icon with hamburger (#527), removes the "X" icon when hammer-screwdriver button is active, and replaces the lock icon in mosviz introduced in #918 (see before and after screenshots below).
Before:
After:
Fixes #527
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.CHANGES.rst?