Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix active state of menu buttons when closing on click away #943

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 19, 2021

Description

This pull request fixes the case from #940 where the active state (orange background color) of a menu button could get out of sync if the menu was closed by clicking off the menu instead of on the button itself.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

* unlike manual buttons, menus can be closed by clicking off the element (since we don't use close-on-click="fase").  This could result in the active state of the button getting out-of-sync with the open state of the menu.  Using v-model on the menu instead of @click on the button keeps these in sync.
@kecnry kecnry added UI/UX😍 no-changelog-entry-needed changelog bot directive labels Oct 19, 2021
@kecnry kecnry added this to the 2.1 milestone Oct 19, 2021
@github-actions github-actions bot added the embed Regarding issues with front-end embedding label Oct 19, 2021
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

@pllim
Copy link
Contributor

pllim commented Oct 19, 2021

CI acted weird. Closing/re-opening to kick it off again.

@pllim pllim closed this Oct 19, 2021
@pllim pllim reopened this Oct 19, 2021
@pllim
Copy link
Contributor

pllim commented Oct 19, 2021

I don't think this needs two approvals since it fixes a bug of another patch that is approved.

@pllim pllim added the trivial Only needs one approval instead of two label Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #943 (40d10bb) into main (e76e2be) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   69.52%   69.40%   -0.13%     
==========================================
  Files          69       69              
  Lines        4880     4880              
==========================================
- Hits         3393     3387       -6     
- Misses       1487     1493       +6     
Impacted Files Coverage Δ
...configs/default/plugins/data_tools/file_chooser.py 65.71% <0.00%> (-3.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e76e2be...40d10bb. Read the comment docs.

@pllim pllim merged commit 3dbc20f into spacetelescope:main Oct 19, 2021
@kecnry kecnry deleted the fix-active-state-click-away branch October 20, 2021 12:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
embed Regarding issues with front-end embedding no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants