Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IP GC scan all running unhealthy #1882

Closed
Icarus9913 opened this issue Jun 12, 2023 · 0 comments · Fixed by #1883
Closed

IP GC scan all running unhealthy #1882

Icarus9913 opened this issue Jun 12, 2023 · 0 comments · Fixed by #1883
Assignees
Labels
kind/bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@Icarus9913
Copy link
Collaborator

Describe the version
version about:

  1. spiderpool v0.5.0 and upper

Describe the bug
The IP GC scan all not works

How To Reproduce
Steps to reproduce the issue:

Additional context
Reference PR: #1661
In this PR, I triggered IP-GC scan all once the spiderpool-controller gets the leader.
But I missed one thing, the startPodInformer and monitorGCSignal run in goroutines.
So the startPodInformer function may run faster and it send a signal to s.gcSignal. What's more, the buffer of s.gcSignal is one, and if function 'monitorGCSignal' runs later and it also wanna send a signal to s.gcSignal and it will block.

s.gcSignal <- struct{}{}

logger.Debug("initial scan all for cluster firstly")
s.gcSignal <- struct{}{}

@Icarus9913 Icarus9913 self-assigned this Jun 12, 2023
@ty-dc ty-dc added kind/bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed pr/release/bug labels Jun 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants