fix IP GC scan all running unhealthy #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icarus9913
added
pr/release/bug
pr/ready-review
Codecov Report
@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
- Coverage 81.81% 81.29% -0.52%
==========================================
Files 49 49
Lines 5218 5218
==========================================
- Hits 4269 4242 -27
- Misses 788 819 +31
+ Partials 161 157 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Icarus9913 <icaruswu66@qq.com>
This was referenced Jun 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I make the
monitorGCSignalinitial scan all signal sending runs in goroutine. And it surely not blocks the for loop.Signed-off-by: Icarus9913 icaruswu66@qq.com
What this PR does / why we need it:
fix bug
Which issue(s) this PR fixes:
close #1882