Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix IP gc not in time #1661

Merged
merged 1 commit into from
Apr 14, 2023
Merged

fix IP gc not in time #1661

merged 1 commit into from
Apr 14, 2023

Conversation

Icarus9913
Copy link
Collaborator

@Icarus9913 Icarus9913 commented Apr 13, 2023

Refer to [#1662], If we trigger IP GC san all when a spiderpool-controller pod gets the leader. It will solve this issue, because the pod informer mechanism also ready too.

Signed-off-by: Icarus9913 icaruswu66@qq.com

What this PR does / why we need it:
fix bug

Which issue(s) this PR fixes:
#1662

Signed-off-by: Icarus9913 <icaruswu66@qq.com>
@Icarus9913 Icarus9913 added pr/release/bug pr/ready-review This pull is ready for review labels Apr 13, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 5 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.5% 4.5% Duplication

@Icarus9913 Icarus9913 linked an issue Apr 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1661 (228c40f) into main (df77684) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1661   +/-   ##
=======================================
  Coverage   75.12%   75.12%           
=======================================
  Files          45       45           
  Lines        4715     4715           
=======================================
  Hits         3542     3542           
  Misses       1065     1065           
  Partials      108      108           
Flag Coverage Δ
unittests 75.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@iiiceoo iiiceoo self-assigned this Apr 14, 2023
@iiiceoo iiiceoo merged commit 03f7c90 into spidernet-io:main Apr 14, 2023
@Icarus9913 Icarus9913 changed the title fix IP gc fix IP gc not in time Apr 14, 2023
@Icarus9913 Icarus9913 deleted the fix/wk/ip-gc branch April 14, 2023 06:08
@ty-dc ty-dc mentioned this pull request Apr 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pr/ready-review This pull is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IP GC not in time
2 participants