provider/kubernetes: Upsert load balancer #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,11 +1,11 @@ | |||
| /* | |||
| * Copyright 2016 Google, Inc. | |||
| * Copyright 2016 Netflix, Inc. | |||
There was a problem hiding this comment.
Whoops, just noticed the license headers were thrown off by IntelliJ. I'll update these in the morning.
lwander
force-pushed
the
kubernetes-load-balancer-create
branch
from
736b0f0 to
7d687a1
Compare
| } | ||
| } | ||
|
|
||
| def validateIpv4(String value, String attribute) { |
There was a problem hiding this comment.
def result = InetAddressUtils.isIPv4Address(value)
if (!result) {
errors.rejectValue(...)
}
result
|
LGTM with comments. |
lwander
force-pushed
the
kubernetes-load-balancer-create
branch
from
7d687a1 to
68e448b
Compare
lwander
force-pushed
the
kubernetes-load-balancer-create
branch
from
68e448b to
e6db61f
Compare
lwander
added a commit
that referenced
this pull request
Feb 12, 2016
provider/kubernetes: Upsert load balancer
luba239
pushed a commit
to vasiliy-briginets/clouddriver
that referenced
this pull request
Mar 5, 2020
ttomsu
pushed a commit
to ttomsu/clouddriver
that referenced
this pull request
Mar 11, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements upsert load balancer for kubernetes.
Load balancers are represented as kuberentes services (and can optionally be backed by a cloud provider's load balancer, when possible).
Relationships between load balancers and instances (pods) are maintained using labels & selectors.
@duftler