provider/kubernetes: Cache & expose kubernetes services as load balancers. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.namespace = service.metadata.namespace | ||
| this.region = this.namespace | ||
| this.accountName = accountName | ||
| this.serverGroups = serverGroupList.collect { KubernetesServerGroup serverGroup |
There was a problem hiding this comment.
Would serverGroupList.groupBy { it.name } work here?
There was a problem hiding this comment.
didn't know that existed, good idea.
There was a problem hiding this comment.
Doesn't work in this case since we are returning a set of maps, not just a single map.
|
LGTM |
lwander
force-pushed
the
kubernetes-cache-load-balancers
branch
from
7f9804d to
b61c714
Compare
lwander
added a commit
that referenced
this pull request
Feb 12, 2016
provider/kubernetes: Cache & expose kubernetes services as load balancers.
| @@ -0,0 +1,67 @@ | |||
| Inferred project: clouddriver, version: 1.49.0-SNAPSHOT | |||
There was a problem hiding this comment.
@lwander Looks like your log file got checked-in by accident.
luba239
pushed a commit
to vasiliy-briginets/clouddriver
that referenced
this pull request
Mar 5, 2020
ttomsu
pushed a commit
to ttomsu/clouddriver
that referenced
this pull request
Mar 11, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements & adds a load balancer
CachingAgent, well as a load balancerProvider.This PR is most useful in conjunction with #307.