spk-convert-pip updates for handling open3d #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 16, 2024 10:56
Signed-off-by: J Robert Ray <jrray@imageworks.com>
Some wheel files are very large and can't be downloaded within the default 10 second timeout window. Signed-off-by: J Robert Ray <jrray@imageworks.com>
This solves a problem parsing some packages which ends up with `info.name` being `None`. Add an assertion to make the problem more clear in the future if it comes back. Bump package version to 1.4.2 (1.4.1 was used in an internal release at SPI). Signed-off-by: J Robert Ray <jrray@imageworks.com>
rydrman
approved these changes
Jul 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the timeout for pip download and update pkginfo to fix the package name not getting set.