Merge pull request #1078 from spkenv/spk-convert-pip-timeout

spk-convert-pip updates for handling open3d
spkenv · Jul 18, 2024 · 5bc6371 · 5bc6371
2 parents 0aafb1f + 1ef30d7
commit 5bc6371
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/packages/spk-convert-pip/requirements.txt b/packages/spk-convert-pip/requirements.txt
@@ -1,5 +1,6 @@
-pkginfo==1.7.0
+# 1.10.0 is the last version that supports python 3.7
+pkginfo==1.10.0
 packaging==20.9
 # 0.40.0 latest at time of writing but no implied requirement for exactly this
 # version.
-wheel==0.40.0
+wheel==0.40.0
diff --git a/packages/spk-convert-pip/spk-convert-pip b/packages/spk-convert-pip/spk-convert-pip
@@ -199,6 +199,8 @@ class PipImporter:
                 pip_command = [
                     "pip",
                     "download",
+                    # Allow enough time for larger wheels to download.
+                    "--timeout=1000",
                     f"{req}",
                     "--python-version",
                     self._python_version,
@@ -284,6 +286,7 @@ class PipImporter:
     def _process_package(
         self, requester: Requirement, info: pkginfo.Distribution
     ) -> List[Dict[str, Any]]:
+        assert info.name, "A package name is required"
         assert not info.requires, "No support for installation requirements"
         assert not info.requires_external, "No support for external requirements"
         assert not info.supported_platforms, "No support for supported platforms field"

diff --git a/packages/spk-convert-pip/spk-convert-pip.spk.yaml b/packages/spk-convert-pip/spk-convert-pip.spk.yaml
@@ -1,4 +1,4 @@
-pkg: spk-convert-pip/1.4.0
+pkg: spk-convert-pip/1.4.2
 api: v0/package
 build:
   script: