Provide expiry and bufferLength configuration properties for configuring a distribution statistic #27584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pr/18383: Mention Java 13 in system requirements docs Closes spring-projectsgh-18383
* pr/18384: Polish some external documentation links Closes spring-projectsgh-18384
Replace `{vbar}` with an escaped pipe character. Unfortunately
`{vbar}` does not render correctly with PDF generation.
See spring-projectsgh-18374
* pr/18374: Simplify pipe escaping for reference doc tables Avoid need to escape pipe character in reference tables Closes spring-projectsgh-18374
Add an appication context initializer to detect and store the active RSocket port in the Environment under `local.rsocket.server.port`. Additionally add a `@LocalServerPort` that provides a convenient alternative to `@Value`. See spring-projectsgh-18287 Co-authored-by: Eddú Meléndez <eddu.melendez@gmail.com>
* pr/18287: Polish 'Add @LocalRSocketServerPort support' Add @LocalRSocketServerPort support Closes spring-projectsgh-18287
Polish code and relocate `RSocketServerBootstrap` from `server` to `context` since it's really an `ApplicationContext` concern. Closes spring-projectsgh-18391
Fix a package tangle that was introduced when we added cache bypass to `SpringIterableConfigurationPropertySource`. Ideally we should have been able to depend on `env` from `context` but unfortunately the `EnvironmentPostProcessor` interface references `SpringApplication` which needs to use the Binder. The `isImmutable` method has now been moved to `OriginLookup` which removes the immediate tangle. Closes spring-projectsgh-18393
Fix package tangle in devtools by relocating `DevToolsEnablementDeducer` to a new `system` package. Closes spring-projectsgh-18393
This reverts commit 8d9e447.
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
requested changes
Aug 6, 2021
.../src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/MetricsProperties.java
Show resolved
Hide resolved
.../src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/MetricsProperties.java
Show resolved
Hide resolved
snicoll
added
the
status: waiting-for-feedback
No problem. I'm worried that my descriptions can't be accurately expressed. Can you review the comments? |
spring-projects-issues
added
status: feedback-provided
|
No worries, I can polish as part of the merge. Can you please add some tests? |
snicoll
added
status: waiting-for-feedback
Sure. I'll add some tests in PropertiesMeterFilterTests. |
spring-projects-issues
added
status: feedback-provided
snicoll
added
status: waiting-for-feedback
|
some tests have been added, please review. |
spring-projects-issues
added
status: feedback-provided
snicoll
changed the title
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Aug 16, 2021
snicoll
added a commit
that referenced
this pull request
Aug 16, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enhance the 27477.