Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Auto-create Pulsar topics #64

Closed
wants to merge 6 commits into from

Conversation

alpreu
Copy link
Contributor

@alpreu alpreu commented Aug 15, 2022

WIP PR for #41 , not review ready

@sobychacko
Copy link
Collaborator

Thanks, @alpreu. This is a great start. This is precisely something we had in mind as a high-priority feature item. Much appreciated you started with it. Please let us know once it is ready for review.

Copy link
Collaborator

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alpreu awesome work! I like how you applied the nested testconfig. I made some simplification requests on them as well. This is looking good though. Ping me if you have any questions and thank you for this contribution.

@sobychacko
Copy link
Collaborator

@alpreu, I know this PR is WIP, but some general comments. Please add copyrights and author tags to all the classes. Also, add javadocs on public API methods/classes, etc. We should also make the PulsarAdministration bean auto-configured.

Copy link
Collaborator

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alpreu I added a few minor comments to address but other than that, the code side of this is complete.

I think the final things are:

  • Update docs (as you mentioned earlier)
  • Consider adding this to one or both sample apps

Thanks

@onobc onobc changed the title WIP Auto-create Pulsar topics Auto-create Pulsar topics Aug 24, 2022
@onobc onobc marked this pull request as ready for review August 24, 2022 14:31
@onobc
Copy link
Collaborator

onobc commented Aug 24, 2022

We should also make the PulsarAdministration bean auto-configured.

@sobychacko I would be in favor of doing an immediate follow-on PR for the admin auto-configuration. It will require property updates and tests etc..

/**
* The Pulsar administration contract.
*
* @author Chris Bono
Copy link
Collaborator

@onobc onobc Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep yourself as the single author. We collaborated on it but this is your work my friend. :)

Same goes for all files in here.

@onobc
Copy link
Collaborator

onobc commented Aug 26, 2022

Closed via 4bab93e

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants