Followup "GH-41 Add auto-created topics" #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpreu
commented
Aug 26, 2022
added 2 commits
August 26, 2022 16:41
alpreu
force-pushed
the
followup-new-topics
branch
from
d0ff99e to
946a59b
Compare
onobc
reviewed
Aug 26, 2022
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Aug 26, 2022
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Aug 26, 2022
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Aug 26, 2022
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Show resolved
Hide resolved
onobc
reviewed
Aug 26, 2022
...ure/src/test/java/org/springframework/pulsar/autoconfigure/PulsarAutoConfigurationTests.java
Show resolved
Hide resolved
onobc
reviewed
Aug 26, 2022
spring-pulsar-sample-apps/src/main/java/app1/SpringPulsarBootApp.java
Outdated
Show resolved
Hide resolved
onobc
requested changes
Aug 26, 2022
There was a problem hiding this comment.
@alpreu I have some minor comments and then the concern of which props we should support (admin and regular client). But other than that, looks great and is ready to go. Lets come to conclusion on the properties and then we can get this one merged. Docs look great. Thanks for adding.
EDITED I put a strike through the above concern based on this comment.
added 14 commits
August 29, 2022 10:52
… into followup-new-topics
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds auto-configuration and documentation for #64.