Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow stricter permissions but not looser; Change default permissions to 0400; Correct and improve `unprotected key file' message. #138

Closed
wants to merge 2 commits into from

Conversation

SBell6hf
Copy link

@SBell6hf SBell6hf commented Jan 14, 2022

This pull request:

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jdtw jdtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SBell6hf
Copy link
Author

@jdtw
Copy link
Contributor

jdtw commented Feb 8, 2022

Thanks so much for filing these issues! I found the tests confusing, so I refactored them and fixed the logic error in #141. After that change, I propose we split this PR into two:

  1. Make the error string more descriptive.
  2. Change the default file permissions if needed (I left a comment on the issue).

@SBell6hf SBell6hf closed this Apr 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when file permissions deny access to a file
3 participants