Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix file permission checking in the depot package #141

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

jdtw
Copy link
Contributor

@jdtw jdtw commented Feb 8, 2022

No description provided.

depot/depot.go Outdated
@@ -98,10 +99,10 @@ func (d *FileDepot) Put(tag *Tag, data []byte) error {
return nil
}

// Check returns whether the file at the tag location exists and has the correct permissions
// Check returns whether the file at the tag location exists and has permisisons at least as restrictive as the given tag.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: permissions

@mbyczkowski mbyczkowski self-requested a review February 8, 2022 00:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certstrap allows looser permissions but not stricter, which can lead to security issues
3 participants