Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Respect all sniffs when reviewing PHP_CodeSniffer itself #3914

Closed
wants to merge 5 commits into from
Closed

Respect all sniffs when reviewing PHP_CodeSniffer itself #3914

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
467c6cb
Flag warnings as well as errors
fredden Oct 29, 2023
84cf5af
Ignore Generic.Files.LineLength
fredden Oct 29, 2023
715e259
Adjust working to avoid false positive warning
fredden Oct 29, 2023
affe41c
Fix use of incorrect tag
fredden Oct 29, 2023
a81e466
Remove now-unnecessary upgrade of warning to error
fredden Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<arg name="basepath" value="."/>
<arg name="colors"/>
<arg name="parallel" value="75"/>
<arg value="np"/>
<arg value="p"/>

<!-- Don't hide tokenizer exceptions -->
<rule ref="Internal.Tokenizer.Exception">
Expand All @@ -32,6 +32,7 @@
<exclude name="PEAR.Commenting.FileComment.MissingLinkTag"/>
<exclude name="PEAR.Commenting.FileComment.MissingVersion"/>
<exclude name="PEAR.Commenting.InlineComment"/>
<exclude name="Generic.Files.LineLength"/>
</rule>

<!-- Include some sniffs from other standards that don't conflict with PEAR -->
Expand Down
2 changes: 1 addition & 1 deletion scripts/ValidatePEAR/ValidatePEARPackageXML.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class ValidatePEARPackageXML
*
* @var array
*
* @link https://pear.php.net/manual/en/developers.packagedef.intro.php#developers.packagedef.roles
* @see https://pear.php.net/manual/en/developers.packagedef.intro.php#developers.packagedef.roles
*/
private $validRoles = [
'data' => true,
Expand Down
2 changes: 1 addition & 1 deletion src/Standards/Generic/Sniffs/Commenting/TodoSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Warns about TODO comments.
* Warns about to-do comments.
*
* @author Greg Sherwood <gsherwood@squiz.net>
* @copyright 2006-2015 Squiz Pty Ltd (ABN 77 084 670 600)
Expand Down
2 changes: 1 addition & 1 deletion src/Standards/Generic/Tests/Commenting/TodoUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Unit test class for the Todo sniff.
* Unit test class for the to-do sniff.
*
* @author Greg Sherwood <gsherwood@squiz.net>
* @copyright 2006-2015 Squiz Pty Ltd (ABN 77 084 670 600)
Expand Down
2 changes: 1 addition & 1 deletion src/Util/Tokens.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ final class Tokens
*
* @var array <int|string> => <int|string>
*
* @link https://www.php.net/language.constants.predefined PHP Manual on magic constants
* @see https://www.php.net/language.constants.predefined PHP Manual on magic constants
*/
public static $magicConstants = [
T_CLASS_C => T_CLASS_C,
Expand Down
Loading