Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Configure electron-builder for executable creation #52

Closed
wants to merge 13 commits into from

Conversation

colfax23
Copy link
Contributor

@colfax23 colfax23 commented Sep 9, 2021

Implementation for #7 using electron-builder. Works on Mac and linux.

@colfax23 colfax23 changed the title Cs/electron builder Configure electron-builder for executable creation Sep 9, 2021
@colfax23 colfax23 requested a review from remyroy September 9, 2021 16:39
@colfax23 colfax23 marked this pull request as draft September 9, 2021 21:34
@colfax23 colfax23 force-pushed the cs/electron-builder branch from 1896bce to 85b48d1 Compare September 9, 2021 21:35
@remyroy
Copy link
Member

remyroy commented Sep 10, 2021

Verifying and testing this right now.

@colfax23
Copy link
Contributor Author

@remyroy awesome. It is not going to work fully yet as the python executable isnt in there yet, but I just got it working locally so will be checking that in soon :)

@remyroy
Copy link
Member

remyroy commented Sep 10, 2021

Bundling the deb package works fine with electron-builder.

It would be nice to add an AppImage target in addition to the deb target so the app can be distributed as some kind of portable app and easily ran on non-debian distros and on distro will limited capacity to install app (Tails with default settings?).

I'll wait full integration to complete the review.

@colfax23 colfax23 marked this pull request as ready for review September 10, 2021 17:51
@colfax23
Copy link
Contributor Author

@remyroy it is ready for review now. Should work fully, let me know any issues.

Agreed on AppImage target, but I had trouble getting the desktop icon to work for AppImage. Will give it another look.

@colfax23
Copy link
Contributor Author

Created #59 for future AppImage target.

@colfax23 colfax23 closed this Sep 13, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants