-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Configure electron-builder for executable creation #52
Conversation
1896bce
to
85b48d1
Compare
Verifying and testing this right now. |
@remyroy awesome. It is not going to work fully yet as the python executable isnt in there yet, but I just got it working locally so will be checking that in soon :) |
Bundling the deb package works fine with electron-builder. It would be nice to add an AppImage target in addition to the deb target so the app can be distributed as some kind of portable app and easily ran on non-debian distros and on distro will limited capacity to install app (Tails with default settings?). I'll wait full integration to complete the review. |
@remyroy it is ready for review now. Should work fully, let me know any issues. Agreed on AppImage target, but I had trouble getting the desktop icon to work for AppImage. Will give it another look. |
Created #59 for future AppImage target. |
Implementation for #7 using electron-builder. Works on Mac and linux.