Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Python bundling on Windows and fixes for Windows support #55

Merged
merged 7 commits into from
Sep 20, 2021
Merged

Python bundling on Windows and fixes for Windows support #55

merged 7 commits into from
Sep 20, 2021

Conversation

remyroy
Copy link
Member

@remyroy remyroy commented Sep 10, 2021

Completes #37

Still a work in process. Needs a few tweaks for more reliability.

@remyroy remyroy changed the title Python bundling win and fixes for Windows support Python bundling on Windows and fixes for Windows support Sep 10, 2021
@colfax23
Copy link
Contributor

This may conflict a little with #52 due to handling the bundled SFE in the clickable executable. Maybe take a look at #52 when you get a chance, let's get it merged, then work off of that?

@remyroy
Copy link
Member Author

remyroy commented Sep 10, 2021

Sure, I'll do that. #52 first than merge from there

@remyroy remyroy mentioned this pull request Sep 13, 2021
Merged
@remyroy remyroy linked an issue Sep 15, 2021 that may be closed by this pull request
Windows support #37
Closed
@remyroy remyroy marked this pull request as draft September 15, 2021 16:47
@remyroy remyroy linked an issue Sep 16, 2021 that may be closed by this pull request
Cross Platform Enhancements #60
Closed
@remyroy remyroy requested a review from colfax23 September 16, 2021 14:55
@remyroy
Copy link
Member Author

remyroy commented Sep 16, 2021

This is ready for review.

@remyroy remyroy marked this pull request as ready for review September 16, 2021 15:34
colfax23
colfax23 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@colfax23 colfax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Tested on MacOS. Nice work, glad it works on windows!

@colfax23 colfax23 merged commit a05b357 into stake-house:main Sep 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@colfax23 colfax23 colfax23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross Platform Enhancements Windows support
2 participants
@remyroy @colfax23