Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow datasets to be the iterator for a dynamic PageView #48

Merged
merged 13 commits into from
Apr 26, 2017

Conversation

allejo
Copy link
Member

@allejo allejo commented Apr 17, 2017

Summary

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed issues #47

Description

Add the ability to iterator through datasets the same way a dynamic PageView can iterator through a collection

To do

  • Jail the DataItem objects
  • Actually make the dataset FM key work

Check List

  • Added appropriate PhpDoc for modifications
  • Added unit test to ensure fix works as intended

@allejo allejo added Feature: Implementation A tag for PRs to signify it's implementing a new feature WIP labels Apr 17, 2017
@allejo allejo added this to the v0.1.1 milestone Apr 17, 2017
@allejo allejo force-pushed the feature/47-dataset-pageview branch 5 times, most recently from 3a7e236 to b772f63 Compare April 24, 2017 03:33
@allejo allejo force-pushed the feature/47-dataset-pageview branch from b772f63 to 5b08da3 Compare April 24, 2017 06:19
@allejo allejo force-pushed the feature/47-dataset-pageview branch from 5b08da3 to 644027f Compare April 24, 2017 07:01
@allejo allejo merged commit ffd4d61 into master Apr 26, 2017
@allejo allejo deleted the feature/47-dataset-pageview branch April 26, 2017 18:08
@allejo allejo removed the WIP label Apr 26, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Feature: Implementation A tag for PRs to signify it's implementing a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant