Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Code ownres from the best of my knowledge #51

Closed
wants to merge 1 commit into from
Closed

Code ownres from the best of my knowledge #51

wants to merge 1 commit into from

Conversation

yfisyak
Copy link
Contributor

@yfisyak yfisyak commented Jul 2, 2021

No description provided.

@yfisyak
Copy link
Contributor Author

yfisyak commented Jul 2, 2021

Update code owners from the best my knowledge

@yfisyak yfisyak closed this Jul 2, 2021
@yfisyak yfisyak reopened this Jul 2, 2021
plexoos
plexoos requested changes Jul 6, 2021
View reviewed changes
Copy link
Member

@plexoos plexoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax of the proposed changes is wrong. Merging it here or as part of #52 will cause the entire file to be ignored.

@veprbl
Copy link
Member

veprbl commented Jul 6, 2021

The syntax of the proposed changes is wrong. Merging it here or as part of #52 will cause the entire file to be ignored.

Can you clarify which part is broken? Is it the maintainerless lines?

@plexoos
Copy link
Member

plexoos commented Jul 6, 2021

Yes

The pattern is followed by one or more GitHub usernames

@veprbl
Copy link
Member

veprbl commented Jul 6, 2021 •
edited
Loading

Yes

The pattern is followed by one or more GitHub usernames

Strange. That would mean that one can not remove all maintainers for a subdirectory. Should be easy to fix this PR though.

@starsdong starsdong mentioned this pull request Jul 17, 2021
Merged
@plexoos
Copy link
Member

plexoos commented Aug 5, 2021

I believe this PR was superseded by #60. Shall we then close this one?

@starsdong
Copy link
Member

Dmitri, Yes. I would agree.

@starsdong starsdong closed this Aug 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@plexoos plexoos plexoos requested changes

@nigmatkulov nigmatkulov Awaiting requested review from nigmatkulov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yfisyak @veprbl @plexoos @starsdong @fisyak