Introduce run time switch for dN/dx calculation #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take a review of the proposed changes. It is not ideal, but will certainly can do the work. And hopefully OK with everyone. If no objection is raised, I would propose to merge this to the main branch by COB tomorrow so we can prepare the library for upcoming BES-II production. |
plexoos
reviewed
Jul 15, 2021
|
Hi All, do we still need one approval to get the PR merged? |
|
Xin, Are you ok with incorporating my suggestions above? If so, I can clean up and merge the squashed commits. I believe @genevb is fine with the change |
|
OK, I am fine with the change. Let us merge them to assemble the library. |
plexoos
approved these changes
Jul 16, 2021
BassamAboona
pushed a commit
to BassamAboona/star-sw
that referenced
this pull request
Jul 30, 2021
Add skipdNdx option to BFC in order to force disable dN/dx calculation Co-authored-by: Yuri Fisyak <fisyak@bnl.gov> Co-authored-by: starsdong <XDong@lbl.gov> Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add skipdNdx option to BFC in order to force disable dN/dx calculations