Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: missing snip-12 enum type dependency #1289

Merged

Conversation

xJonathanLEI
Copy link
Contributor

Motivation and Resolution

Resolves #1287.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

Copy link
Collaborator

@penovicp penovicp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test message example similar to __mocks__/typedData/example_enum.json and corresponding tests for encodeType, getTypeHash, and getMessageHash so the issue that the PR fixes is covered in case of future code changes?

@xJonathanLEI
Copy link
Contributor Author

Sure thing. Sorry I should have added the tests to start with. I will generate the tests using my impl in starknet-rs.

@penovicp penovicp force-pushed the dev/snip_12_enum_dep branch from ce7dbe0 to e57eaf3 Compare January 7, 2025 09:46
@penovicp penovicp changed the base branch from develop to fix/snip-12-enum January 7, 2025 12:58
@penovicp penovicp merged commit 0e0a3eb into starknet-io:fix/snip-12-enum Jan 7, 2025
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNIP-12 enum type encoding fails to include referenced types except when used alone
2 participants