feat: snip-12 typed data parsing and hashing #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xJonathanLEI
force-pushed
the
dev/snip_12
branch
from
b777c73 to
63a73d1
Compare
xJonathanLEI
force-pushed
the
dev/snip_12
branch
from
63a73d1 to
73cdb6b
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #671.
Adds a new type
TypedDatathat's deserializable from JSON. Computing message hashes is supported with the.message_hash()function.Test cases are generated with a patched fork of
starknet.jswith these 2 pending PRs picked::in enum encoding starknet-io/starknet.js#1288