Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Regionalise the display of eth and better decimal/comma handling. #754

Closed
0xc1c4da opened this issue Jan 23, 2017 · 0 comments
Closed

Regionalise the display of eth and better decimal/comma handling. #754

0xc1c4da opened this issue Jan 23, 2017 · 0 comments
Assignees
@alwx
Milestone
0.9.3

Comments

@0xc1c4da
Copy link
Contributor

We allowed #665 #746 issue and pull request through and I think this could be handled better.

For example it doesn't appear we handle number formats like 10,000,000.00 or it's opposite 10.000.000,00 ?

At the moment the display of ETH is not regionalised, and we're defaulting decimal place we should make this better, we can also fix #645 at the same time.
@alwx alwx self-assigned this Jan 23, 2017
alwx added a commit that referenced this issue Jan 23, 2017
@alwx
Localization of request data and previews (#645, #754)
569e16c
@alwx alwx mentioned this issue Jan 24, 2017
Merged
@alwx alwx added ready and removed in progress labels Jan 24, 2017
alwx added a commit that referenced this issue Jan 24, 2017
@alwx
Generating message preview on the fly, localization of request data a…
8663bdf 
…nd previews (#645, #754)
alwx added a commit that referenced this issue Jan 26, 2017
@alwx
Generating message preview on the fly, localization of request data a…
6134bfd 
…nd previews (#645, #754)
alwx added a commit that referenced this issue Jan 31, 2017
@alwx
Generating message preview on the fly, localization of request data a…
6abd5c9 
…nd previews (#645, #754)
rasom pushed a commit that referenced this issue Feb 1, 2017
@alwx @rasom
Generating message preview on the fly, localization of request data a…
78e7057 
…nd previews (#645, #754)
@alwx alwx closed this as completed Feb 3, 2017
@alwx alwx removed the ready label Feb 3, 2017
@0xc1c4da 0xc1c4da modified the milestone: 0.9.3 Feb 4, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@alwx alwx

Labels
None yet
Projects
None yet
Milestone
0.9.3
Development

No branches or pull requests
2 participants
@alwx @0xc1c4da