Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Alternate Currency Formats breaks ability to send ETH (#665) #746

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Alternate Currency Formats breaks ability to send ETH (#665) #746

merged 1 commit into from
Jan 20, 2017

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Jan 19, 2017

#665

Since all countries use either comma or point as a decimal mark (https://en.wikipedia.org/wiki/Decimal_mark), simple replace works great here.

@alwx alwx added the ready label Jan 19, 2017
@alwx alwx self-assigned this Jan 19, 2017
@alwx alwx requested a review from rasom January 19, 2017 15:23
@0xc1c4da
Copy link
Contributor

we should also regionalise the display of eth, i guess is similar to #645

@rasom
Copy link
Contributor

rasom commented Jan 20, 2017

@jarradh, maybe it is better to create another issue regarding regionalisation?

@rasom rasom merged commit a4526f7 into develop Jan 20, 2017
@rasom rasom deleted the bug/#665 branch January 20, 2017 14:00
@0xc1c4da
Copy link
Contributor

sure

@0xc1c4da 0xc1c4da mentioned this pull request Jan 23, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rasom rasom Awaiting requested review from rasom

Assignees

@alwx alwx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alwx @0xc1c4da @rasom