Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fails to rewrap a markdown file if there is a commented-out code block #288

Closed
whitepau opened this issue Sep 28, 2021 · 3 comments
Closed

Comments

@whitepau
Copy link

I've attached a markdown file that exhibits this bug. The paragraphs after a commented-out code block fail to rewrap, but the paragraphs before are fine.
test.md


> this paragraph will wrap correctly 
> 
> <!--
> ```
> some code
> ```
> -->
> 
> This paragraph will not

stkb added a commit that referenced this issue Nov 29, 2021
Scenario: line containing just `<!--` after a blank line. The non-text
parser was starting a block on the blank line and continuing its block
on the `<!--` line since it was also non-text. Now the non-text parser
only ever makes a 1-line block so that each new line can be fully
evaluated by the language parser.
@stkb
Copy link
Owner

stkb commented Nov 29, 2021

Thanks for the test case! This will be fixed in the next version.

@stkb stkb added the in pre-release version Is in pre-release version but not in stable yet label Nov 29, 2021
@whitepau
Copy link
Author

Thanks!

stkb added a commit that referenced this issue Dec 19, 2021
Scenario: line containing just `<!--` after a blank line. The non-text
parser was starting a block on the blank line and continuing its block
on the `<!--` line since it was also non-text. Now the non-text parser
only ever makes a 1-line block so that each new line can be fully
evaluated by the language parser.
stkb added a commit that referenced this issue Jan 14, 2022
- New architecture (still WIP) with performance increase.
- Markdown: new parser that fixes many small bugs (inc #288), as well as
  supporting:
  - Front matter header (#277, #294)
  - Link reference definitions (#63, #93)
  - Footnotes (#188)
- ReStructuredText support (standalone & for Python, almost complete)
  (#88).
- Julia: support `#= ... =#` block comments (#302)
- Visual Studio: Wrap to rulers generated from .editorconfig by the
  Editor Guidelines extension (thereby indirectly supporting
  .editorconfig) (#300).
@stkb
Copy link
Owner

stkb commented Jan 14, 2022

Fixed in v1.16.0

@stkb stkb closed this as completed Jan 14, 2022
@stkb stkb removed the in pre-release version Is in pre-release version but not in stable yet label Jan 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants