Merge branch 'feature/15' into develop

suikan4github · Oct 16, 2024 · 108ebe2 · 108ebe2
2 parents 429c954 + 6302a22
commit 108ebe2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,7 +8,8 @@ The issue #16 changes its public member function. But it is referred internally
 - [Issue #13](https://github.com/suikan4github/rpp_driver/issues/13)  Exclude Mock definition from the GCov coverage. 
 ### Changed
 - [Issue #10](https://github.com/suikan4github/rpp_driver/issues/10) Cover APIs of the Raspberry Pi Pico SDK.
-- [Issue #16](https://github.com/suikan4github/rpp_driver/issues/16)  Change the member function name from ConfigureSRC() to ConfigureSrc().
+- [Issue #15](https://github.com/suikan4github/rpp_driver/issues/15) Remove the redundant parameter check code from ConfigureSRC() 
+- [Issue #16](https://github.com/suikan4github/rpp_driver/issues/16) Change the member function name from ConfigureSRC() to ConfigureSrc().
 ### Deprecated
 ### Removed
 ### Fixed

diff --git a/src/codec/adau1361lower.cpp b/src/codec/adau1361lower.cpp
@@ -512,10 +512,6 @@ void ::rpp_driver::Adau1361Lower::InitializeRegisters() {
 
 // Set the converter clock.
 void ::rpp_driver::Adau1361Lower::ConfigureSrc(unsigned int fs) {
-  assert((fs == 24000 || fs == 32000 || fs == 48000 || fs == 96000 ||
-          fs == 22050 || fs == 44100 || fs == 88200) &&
-         "Bad Fs");
-
   switch (fs) {
     case 22050:
     case 24000: {
@@ -549,7 +545,7 @@ void ::rpp_driver::Adau1361Lower::ConfigureSrc(unsigned int fs) {
       break;
     }
     default:
-      assert(false);
+      assert(false && "Bad Fs");
   }
 }