Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clean up Internal include directive. #14

Closed
suikan4github opened this issue Oct 13, 2024 · 1 comment
Closed

Clean up Internal include directive. #14

suikan4github opened this issue Oct 13, 2024 · 1 comment
Assignees
@suikan4github
Labels
enhancement New feature or request

Comments

@suikan4github
Copy link
Owner

Currently, we use the short file name as an internal include.

#include "sdkwrapper.hpp".

But, this is against the google style guild.

It should be

#include "src/sdk/sdkwrapper.hpp"
@suikan4github suikan4github self-assigned this Oct 15, 2024
@suikan4github suikan4github added the enhancement New feature or request label Oct 15, 2024
suikan4github added a commit that referenced this issue Oct 17, 2024
@suikan4github
Issue #14 : Clean up Internal include directive.
03d8b7b
suikan4github added a commit that referenced this issue Oct 17, 2024
@suikan4github
Add Issue #14 into the CHANGELOG.md.
4fbdcc5
@suikan4github
Copy link
Owner Author

It has been merged into the "develop" branch. Ready to release.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@suikan4github suikan4github

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suikan4github