Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove the redundant parameter check code from ConfigureSRC() #15

Closed
suikan4github opened this issue Oct 13, 2024 · 1 comment
Closed

Remove the redundant parameter check code from ConfigureSRC() #15

suikan4github opened this issue Oct 13, 2024 · 1 comment
Assignees
@suikan4github
Labels
enhancement New feature or request

Comments

@suikan4github
Copy link
Owner

The Adau1361Lower::ConfigureSRC() has redundant parameter checks.

rpp_driver/src/codec/adau1361lower.cpp

Lines 515 to 517 in 2dc5c99

assert((fs == 24000 || fs == 32000 || fs == 48000 || fs == 96000 ||
fs == 22050 || fs == 44100 || fs == 88200) &&
"Bad Fs");

rpp_driver/src/codec/adau1361lower.cpp

Lines 551 to 552 in 2dc5c99

default:
assert(false);

Need to remove the former one.
@suikan4github suikan4github self-assigned this Oct 13, 2024
@suikan4github suikan4github added the enhancement New feature or request label Oct 13, 2024
suikan4github added a commit that referenced this issue Oct 16, 2024
@suikan4github
Issue #15 : Remove the redundant parameter check code from ConfigureS…
29f9eec 
…RC()

The assertion at the top of the rpp_driver::Adau1361Lower::ConfigureSrc()
was redudant becuase the switch-case statement has default to catch the
unkown Fs.

So, the assertion was removed. Death test passed.
suikan4github added a commit that referenced this issue Oct 16, 2024
@suikan4github
Add #15 to the Changelog.
6302a22
@suikan4github
Copy link
Owner Author

Test passed. It was merged to develop. Ready to release.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@suikan4github suikan4github

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suikan4github