Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Invalid private repository SVG image URLs #21

Closed
svengreb opened this issue Jun 26, 2020 · 0 comments · Fixed by #22
Closed

Invalid private repository SVG image URLs #21

svengreb opened this issue Jun 26, 2020 · 0 comments · Fixed by #22
Labels
context-documentation scope-compatibility target-base type-bug
Milestone
0.1.0

Comments

@svengreb
Copy link
Owner

SVG images like the repository hero are currently not rendered because they are using the URLs for public repositories instead of the ones that allow to resolve the files in private repositories:

-https://raw.githubusercontent.com/svengreb/tmpl/master/assets/images/repository-hero.svg?sanitize=true
+https://github.com/svengreb/tmpl/blob/master/assets/images/repository-hero.svg?raw=true
@svengreb svengreb added this to the 0.1.0 milestone Jun 26, 2020
@svengreb svengreb self-assigned this Jun 26, 2020
svengreb added a commit that referenced this issue Jun 26, 2020
@svengreb
Fix invalid private repository SVG image URLs
b458dfb 
SVG images like the repository hero were not rendered because they used
the URLs for public repositories instead of the ones that allow to
resolve the files in private repositories:

```diff
-https://raw.githubusercontent.com/svengreb/tmpl/master/assets/images/repository-hero.svg?sanitize=true
+https://github.com/svengreb/tmpl/blob/master/assets/images/repository-hero.svg?raw=true
```

GH-21
@svengreb svengreb mentioned this issue Jun 26, 2020
Merged
svengreb added a commit that referenced this issue Jun 26, 2020
@svengreb
Fix invalid private repository SVG image URLs (#22)
3844257 
SVG images like the repository hero were not rendered because they used
the URLs for public repositories instead of the ones that allow to
resolve the files in private repositories:

```diff
-https://raw.githubusercontent.com/svengreb/tmpl/master/assets/images/repository-hero.svg?sanitize=true
+https://github.com/svengreb/tmpl/blob/master/assets/images/repository-hero.svg?raw=true
```

Fixes GH-21
@svengreb svengreb removed their assignment Jun 26, 2020
svengreb added a commit that referenced this issue Aug 22, 2020
@svengreb
Fix invalid private repository SVG image URLs (#22)
cc44696 
SVG images like the repository hero were not rendered because they used
the URLs for public repositories instead of the ones that allow to
resolve the files in private repositories:

```diff
-https://raw.githubusercontent.com/svengreb/tmpl/master/assets/images/repository-hero.svg?sanitize=true
+https://github.com/svengreb/tmpl/blob/master/assets/images/repository-hero.svg?raw=true
```

Fixes GH-21
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
context-documentation scope-compatibility target-base type-bug
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Fix invalid private repository SVG image URLs svengreb/tmpl
1 participant
@svengreb