Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix invalid private repository SVG image URLs #22

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

svengreb
Copy link
Owner

@svengreb svengreb commented Jun 26, 2020

Fixes #21

SVG images like the repository hero were not rendered because they used
the URLs for public repositories instead of the ones that allow to
resolve the files in private repositories:

```diff
-https://raw.githubusercontent.com/svengreb/tmpl/master/assets/images/repository-hero.svg?sanitize=true
+https://github.com/svengreb/tmpl/blob/master/assets/images/repository-hero.svg?raw=true
```

GH-21
@svengreb svengreb added this to the 0.1.0 milestone Jun 26, 2020
@svengreb svengreb self-assigned this Jun 26, 2020
@svengreb svengreb merged commit 3844257 into master Jun 26, 2020
@svengreb svengreb deleted the bugfix/gh-21-invalid-private-repo-img-urls branch June 26, 2020 11:13
@svengreb svengreb removed their assignment Jun 26, 2020
svengreb added a commit that referenced this pull request Aug 22, 2020
SVG images like the repository hero were not rendered because they used
the URLs for public repositories instead of the ones that allow to
resolve the files in private repositories:

```diff
-https://raw.githubusercontent.com/svengreb/tmpl/master/assets/images/repository-hero.svg?sanitize=true
+https://github.com/svengreb/tmpl/blob/master/assets/images/repository-hero.svg?raw=true
```

Fixes GH-21
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid private repository SVG image URLs
1 participant