add support for adding a custom http(s) agent #875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node, by default, uses a hardcoded list of CAs instead of the system CAs. In order to use a CA that is not on that list, you have to hack it into the list by patching the global https agent. Unfortunately, superagent explicitly turns off the global agent which makes patching it a no-op. So this PR adds the ability to supply the CA for superagent as an option.