Skip to content

Spelling fix #28

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 3, 2015
Merged

Spelling fix #28

merged 1 commit into from
Dec 3, 2015

Conversation

ArtSabintsev
Copy link
Contributor

Fixed it;s with it's.

Fixed *it;s* with *it's*.
@ArtSabintsev ArtSabintsev changed the title Grammatical fix Spelling fix Dec 3, 2015
tkremenek added a commit that referenced this pull request Dec 3, 2015
@tkremenek tkremenek merged commit 1adf677 into swiftlang:master Dec 3, 2015
DougGregor added a commit to DougGregor/swift that referenced this pull request Apr 20, 2017
Address ABI FIXMEs swiftlang#28, swiftlang#80, swiftlang#81 by making the SubSequence of a filtered
collection into be a filtered collection of the base's
SubSequence rather than a slice of this filtered collection, e.g.,
replace `Slice<LazyFilterCollection<Array<T>>>` with
`LazyFilterCollection<ArraySlice<T>>`, which allows slicing
optimizations of the base type to kick in.

While here, eliminate the vestigial type `LazyFilterIndex`, which was
necessary pre-Swift-3 to allow the index to move. Swift 3's indexing
model means that the movement of indices is on the collection itself,
so we no longer need `LazyFilterIndex`: instead, the `Index` type of
the lazy filtered collection is simply the `Index` type of the base
collection, which is a nice convenience: it means you can take indices
from a lazy wrapper around a given collection C and use them with the
collection C (and, with care, vice-versa) without jumping through
extra hoops.
DougGregor added a commit to DougGregor/swift that referenced this pull request Oct 1, 2017
Rather than using the default slice type when slicing the collection produced
by a lazy map or filter, slice the base collection and form a new
lazy map/filter collection from it. This allows any optimizations provided by
the collection SubSequence type to kick in, as well as ensuring that slicing
a lazy collection provides the same type as producing a lazy collection of a
slice.

This is technically source-breaking, because someone could have spelled out
the types of slicing a lazy filter or map… but it seems unlikely to matter
in practice and the benefits could be significant.

Fixes ABI FIXME’s swiftlang#28 and swiftlang#46.
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
Fix warning: wait.h required by waitpid()
kateinoigakukun referenced this pull request in kateinoigakukun/swift Dec 25, 2019
* [WASM] Remove rpath flag and link objects using llvm-ar instead of ar

* [WASM] Disable objc interop for sil-func-extractor when targeting wasm

* [WASM] Exclude test cases which use -enable-objc-interop

* [WASM] Make availability_returns_twice.swift unsupoorted on wasi due to lack of setjmp
kateinoigakukun referenced this pull request in kateinoigakukun/swift Jan 11, 2020
* [WASM] Remove rpath flag and link objects using llvm-ar instead of ar

* [WASM] Disable objc interop for sil-func-extractor when targeting wasm

* [WASM] Exclude test cases which use -enable-objc-interop

* [WASM] Make availability_returns_twice.swift unsupoorted on wasi due to lack of setjmp
kateinoigakukun referenced this pull request in kateinoigakukun/swift Jan 24, 2020
* [WASM] Remove rpath flag and link objects using llvm-ar instead of ar

* [WASM] Disable objc interop for sil-func-extractor when targeting wasm

* [WASM] Exclude test cases which use -enable-objc-interop

* [WASM] Make availability_returns_twice.swift unsupoorted on wasi due to lack of setjmp
kateinoigakukun referenced this pull request in kateinoigakukun/swift Jan 25, 2020
* [WASM] Remove rpath flag and link objects using llvm-ar instead of ar

* [WASM] Disable objc interop for sil-func-extractor when targeting wasm

* [WASM] Exclude test cases which use -enable-objc-interop

* [WASM] Make availability_returns_twice.swift unsupoorted on wasi due to lack of setjmp
MaxDesiatov pushed a commit to MaxDesiatov/swift that referenced this pull request May 1, 2020
[pull] swiftwasm from apple:master
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
WIP: build-script: teach the script to install SwiftSyntax build.
DougGregor pushed a commit to DougGregor/swift that referenced this pull request Apr 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants