Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Documenting all missing options #2362

Closed
4 of 15 tasks
wouterj opened this issue Mar 26, 2013 · 13 comments
Closed
4 of 15 tasks

Documenting all missing options #2362

wouterj opened this issue Mar 26, 2013 · 13 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Form
Milestone

Comments

@wouterj
Copy link
Member

wouterj commented Mar 26, 2013

The Form Type Reference has some missing options.

How to document it

Most of the missing options are already documented. You should check in the reference/forms/types/options/ directory to find if the option is already documented and if the description is correct for this type. If it is, you should add an include statement in the type reference article:

.. include:: /reference/forms/types/options/read_only.rst.inc

If the description is not correct for this type, you need to document it in the type reference article:

error_bubbling
~~~~~~~~~~~~~~
**type**: ``boolean`` **default**: ``false``

    
Some description and usage of the type.

If there is no documentation about the option and it is used in other types, you should create a new file in the reference/forms/types/options/ directory and include it in the relevant articles.

The Missing Options in 2.0

The options are all linked to the place where they are defined in the core code. However, search in the class to find some usage and other important information about the option you're documenting.

DateTime

Field

Form

Integer

  • precision
    (the docs already exists in the Number type, just create a
    precision.rst.inc and include it in both)

Time

@xabbuh
Copy link
Member

xabbuh commented Nov 4, 2013

Meanwhile (7e06f9f), the following options have been documented:

  • DateTime
    • empty_value
  • Integer
    • precision
  • Number
    • precision
  • Time
    • empty_value

@wouterj
Copy link
Member Author

wouterj commented Nov 4, 2013

thanks @xabbuh, updated the PR

@xabbuh
Copy link
Member

xabbuh commented Nov 4, 2013

What do we do with the Field options as it is not part of Symfony since 2.1?

@stof
Copy link
Member

stof commented Nov 4, 2013

@xabbuh they are part of Symfony, but in the form type

@xabbuh
Copy link
Member

xabbuh commented Nov 4, 2013

I know. I think my question was not clear enough. I'm wondering if this list also applies to the FormType? Specifically, why should the disabled option be removed?

@wouterj
Copy link
Member Author

wouterj commented Nov 4, 2013

@xabbuh disabled was added in 2.1, not 2.0.

This list does not fully apply to 2.1.

@xabbuh
Copy link
Member

xabbuh commented Nov 4, 2013

So that's not a problem anymore.

I'll walk through the list one by one and will provide an updated list.

@stof
Copy link
Member

stof commented Nov 4, 2013

@wouterj for 2.0, disabled was the same option than read_only in 2.1+

@xabbuh
Copy link
Member

xabbuh commented Nov 4, 2013

The following options need to be documented:

  • data_class
  • empty_data
  • max_length
  • pattern
  • by_reference
  • error_bubbling
  • label
  • label_attr
  • compound

@dorians
Copy link

dorians commented Dec 14, 2013

I think some options are already documented. So it's an updated list:

@xabbuh
Copy link
Member

xabbuh commented Dec 15, 2013

@wouterj can you update the list in the description (maybe adding references to the pull requests for each option too)?

dorians pushed a commit to dorians/symfony-docs that referenced this issue Dec 15, 2013
@wouterj
Copy link
Member Author

wouterj commented Dec 15, 2013

@xabbuh I've rechecked everything and updated my form type tree: https://gist.github.com/WouterJ/5246728 I'll update this issue this week

weaverryan pushed a commit that referenced this issue Dec 26, 2013
Create description for "compound" option.
weaverryan pushed a commit that referenced this issue Jan 1, 2014
Create data_class documentation.
@wouterj
Copy link
Member Author

wouterj commented Jan 3, 2014

closing in favor of #3410

@wouterj wouterj closed this as completed Jan 3, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
actionable Clear and specific issues ready for anyone to take them. Form
Projects
None yet
Development

No branches or pull requests

4 participants