document the DateTimeType widget option #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 4, 2013
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | all |
| Fixed tickets | #2362 |
|
|
||
| Defines the ``widget`` option for both the :doc:`date </reference/forms/types/date>` | ||
| type and :doc:`time </reference/forms/types/time>` type. If set, overwrites the | ||
| `date_widget`_ and `time_widget`_ options. |
There was a problem hiding this comment.
I'm checking out the code, and I'm not sure that widget overrides date_widget or time_widget - it looks like if widget is set, it's the default value, but then if date_widget is set, for example, that would override widget. What do you think?
There was a problem hiding this comment.
Yes, that's indeed the case @weaverryan
https://github.com/symfony/Form/blob/master/Extension/Core/Type/DateTimeType.php#L200-208
There was a problem hiding this comment.
Seems you're right. I just relied on the comments here. Fixed it.
weaverryan
added a commit
that referenced
this pull request
Nov 7, 2013
document the DateTimeType widget option
|
Thanks Christian! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.