generated from tophat/new-project-kit
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: detect unused snapshots despite xdist #901
Draft
epenet
wants to merge
4
commits into
syrupy-project:main
Choose a base branch
from
epenet:20241015-1013
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2024
3 tasks
aaf0912
to
83152c8
Compare
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #901 +/- ##
==========================================
- Coverage 97.74% 97.34% -0.40%
==========================================
Files 21 21
Lines 1596 1658 +62
==========================================
+ Hits 1560 1614 +54
- Misses 36 44 +8 |
After running successfully on Home Assistant - it was decided to revert it because serialization/de-serialization of the report was taking too long. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve xdist compatibility - with the ability to serialize/deserialize the report data.
See home-assistant/core#128162 for sample implementation
Related Issues
Checklist
Additional Comments
No additional comments.