-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test: Add tests highlighting xdist incompatibilities #902
Conversation
somewhat related to #882 as well though to close out 882 I'd like some way to isolate dependencies as well |
I appreciate the PRs. Getting xdist support in syrupy would be a massive win and anything we can do to move in that direction has my support |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 97.93% 97.74% -0.19%
==========================================
Files 21 21
Lines 1596 1596
==========================================
- Hits 1563 1560 -3
- Misses 33 36 +3 🚨 Try these New Features:
|
@@ -48,29 +48,27 @@ def generate_snapshots(testdir, testcases_initial): | |||
return result, testdir, testcases_initial | |||
|
|||
|
|||
@pytest.mark.xfail(strict=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xfail here is because the test is flakey, haven't figured out why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put the flaky markers back in.
Until my PR is merged, the workflow has to be triggered manually :( but hopefully once my first PR is in I can tweak more easily...
I'll look into getting CI to run without manual approval |
No need - it just applies to first time contributors... and now I'm a second-time contributor |
@all-contributors add @epenet for test |
I've put up a pull request to add @epenet! 🎉 |
🎉 This PR is included in version 4.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Related to #535, and as preliminary work for #901, add tests showing current xdist incompatibilities
Related Issues
Checklist
Additional Comments