Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: Add tests highlighting xdist incompatibilities #902

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Oct 17, 2024

Description

Related to #535, and as preliminary work for #901, add tests showing current xdist incompatibilities

Related Issues

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

@noahnu
Copy link
Collaborator

noahnu commented Oct 19, 2024

somewhat related to #882 as well though to close out 882 I'd like some way to isolate dependencies as well

@noahnu noahnu added the ci/run-all-tests Disables fast fail on test runs label Oct 20, 2024
@noahnu
Copy link
Collaborator

noahnu commented Oct 20, 2024

I appreciate the PRs. Getting xdist support in syrupy would be a massive win and anything we can do to move in that direction has my support

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   97.93%   97.74%   -0.19%     
==========================================
  Files          21       21              
  Lines        1596     1596              
==========================================
- Hits         1563     1560       -3     
- Misses         33       36       +3     

🚨 Try these New Features:

@@ -48,29 +48,27 @@ def generate_snapshots(testdir, testcases_initial):
return result, testdir, testcases_initial


@pytest.mark.xfail(strict=False)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xfail here is because the test is flakey, haven't figured out why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put the flaky markers back in.
Until my PR is merged, the workflow has to be triggered manually :( but hopefully once my first PR is in I can tweak more easily...

@noahnu noahnu merged commit f8b4b03 into syrupy-project:main Oct 21, 2024
15 of 16 checks passed
@noahnu
Copy link
Collaborator

noahnu commented Oct 21, 2024

I'll look into getting CI to run without manual approval

@epenet epenet deleted the 20241017-1303 branch October 21, 2024 12:12
@epenet
Copy link
Contributor Author

epenet commented Oct 21, 2024

I'll look into getting CI to run without manual approval

No need - it just applies to first time contributors... and now I'm a second-time contributor

@noahnu
Copy link
Collaborator

noahnu commented Oct 21, 2024

@all-contributors add @epenet for test

Copy link
Contributor

@noahnu

I've put up a pull request to add @epenet! 🎉

@noahnu
Copy link
Collaborator

noahnu commented Nov 23, 2024

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci/run-all-tests Disables fast fail on test runs released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants