Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wasm service is down and a generator for the ELF executables selection list should be introduced #486

Closed
ChinYikMing opened this issue Sep 1, 2024 · 1 comment · Fixed by #487
Assignees

Comments

@ChinYikMing
Copy link
Collaborator

ChinYikMing commented Sep 1, 2024

Wasm service down after merging #474. The reason is that multiple ELF executables are being placed in the build/linux-x86-softfp and build/riscv32 directories, whereas wasm service expects the ELF executables to be located in the build/ directory.

@ChinYikMing ChinYikMing self-assigned this Sep 1, 2024
@ChinYikMing ChinYikMing changed the title Wasm service down after #474 Wasm service down after merging #474 Sep 1, 2024
@ChinYikMing
Copy link
Collaborator Author

Additionally, the more ELF executables there are, the longer the list of ELF executables becomes in the web page UI. Therefore, a list generator could be utilized to dynamically update the content of the ELF executables list in the web page UI.

@ChinYikMing ChinYikMing changed the title Wasm service down after merging #474 Wasm service is down Sep 1, 2024
ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Sep 1, 2024
After merging sysprog21#474, multiple executables were moved to other locations
(e.g., build/riscv32), causing the wasm service to fail. The intuitive
solution is to embed build/riscv32 into the wasm.

Additionally, the Makefile's distclean target does not fully clean wasm
artifacts, as CC=emcc might not be set during make distclean. To fix
this, the declaration of the WEB_FILES and DEMO_DIR wasm-related
variables has been reordered.

Related: sysprog21#486
ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Sep 1, 2024
After merging sysprog21#474, multiple executables were moved to other location
(build/riscv32), which caused the wasm service to fail. The intuitive
solution is to embed build/riscv32 into the wasm. Also, executables that
stored in rv32emu-prebuilt must be pulled before embedding into wasm, so
emcc_deps should depend on the artifact target.

Additionally, the Makefile's distclean target does not fully clean wasm
artifacts, as CC=emcc might not be set during make distclean. To fix
this, the declaration of the WEB_FILES and DEMO_DIR wasm-related
variables has been reordered.

Related: sysprog21#486
@ChinYikMing ChinYikMing changed the title Wasm service is down Wasm service is down and a generator for the ELF executables selection list should be introduced. Sep 1, 2024
@ChinYikMing ChinYikMing changed the title Wasm service is down and a generator for the ELF executables selection list should be introduced. Wasm service is down and a generator for the ELF executables selection list should be introduced Sep 1, 2024
ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Sep 1, 2024
As the number of ELF executables may increase over time, manually
updating the HTML ELF list becomes tedious. Therefore, an ELF list
generator has been introduced. When new ELF executables are added to
the build or build/riscv32 directories, the list will be generated
dynamically.

Close: sysprog21#486
ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Sep 1, 2024
As the number of ELF executables may increase over time, manually
updating the HTML ELF list becomes tedious. Therefore, an ELF list
generator has been introduced. When new ELF executables are added to
the build or build/riscv32 directories, the list will be generated
dynamically.

Close: sysprog21#486
@jserv jserv added this to the release-2024.1 milestone Sep 2, 2024
ChinYikMing added a commit to ChinYikMing/rv32emu that referenced this issue Sep 2, 2024
After merging sysprog21#474, multiple executables were moved to other location
(build/riscv32), which caused the wasm service to fail. The intuitive
solution is to embed build/riscv32 into the wasm. Also, executables that
stored in rv32emu-prebuilt must be pulled before embedding into wasm, so
emcc_deps should depend on the artifact target.

Additionally, the Makefile's distclean target does not fully clean wasm
artifacts, as CC=emcc might not be set during make distclean. To fix
this, the declaration of the WEB_FILES and DEMO_DIR wasm-related
variables has been reordered.

Related: sysprog21#486
@jserv jserv closed this as completed in #487 Sep 2, 2024
@jserv jserv closed this as completed in 785bf15 Sep 2, 2024
vestata pushed a commit to vestata/rv32emu that referenced this issue Jan 24, 2025
After merging sysprog21#474, multiple executables were moved to other location
(build/riscv32), which caused the wasm service to fail. The intuitive
solution is to embed build/riscv32 into the wasm. Also, executables that
stored in rv32emu-prebuilt must be pulled before embedding into wasm, so
emcc_deps should depend on the artifact target.

Additionally, the Makefile's distclean target does not fully clean wasm
artifacts, as CC=emcc might not be set during make distclean. To fix
this, the declaration of the WEB_FILES and DEMO_DIR wasm-related
variables has been reordered.

Related: sysprog21#486
vestata pushed a commit to vestata/rv32emu that referenced this issue Jan 24, 2025
As the number of ELF executables may increase over time, manually
updating the HTML ELF list becomes tedious. Therefore, an ELF list
generator has been introduced. When new ELF executables are added to
the build or build/riscv32 directories, the list will be generated
dynamically.

Close: sysprog21#486
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants